Skip to content

Added:#35

Open
crsndr wants to merge 4 commits intoevenup:masterfrom
crsndr:master
Open

Added:#35
crsndr wants to merge 4 commits intoevenup:masterfrom
crsndr:master

Conversation

@crsndr
Copy link

@crsndr crsndr commented Nov 4, 2015

$ldap_group_search_base = 'ou=Groups,dc=org',
$ldap_user_search_base = 'ou=People,dc=org',

parameters

  $ldap_group_search_base = 'ou=Groups,dc=org',
  $ldap_user_search_base = 'ou=People,dc=org',

parameters
@jlambert121
Copy link
Contributor

Thanks for the PR. Would you line up the properties in the class and I think this property should start undefined and only set the parameters when set. If you could add some tests to make sure the properties are set/unset too.

- chek if the proprerties are set
@jlambert121
Copy link
Contributor

Thanks for updating that. I was just ready to merge it and noticed there wasn't any tests around this. Sorry I missed that the first time, could you put a test in for default and for set and then it's good to go!

@crsndr
Copy link
Author

crsndr commented Nov 23, 2015

Is there still anything that should be done before it can be merged?

@jlambert121
Copy link
Contributor

Sorry - GH doesn't email with just code changes so I didn't see them. Would you add a test to make sure the undef parameter isn't added, squish it all into a single commit and I'll merge it. If you'd throw a comment on that would be great so I don't miss it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants